Audit TlsSession APIs test coverage
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Description
> this will call validation again? I'm not sure the existing code will handle it right: _externalPendingCert = null. Tracking certificates was always tricky IMHO. It may go beyond this PR but I'm wondering if we can construct some tests to make sure all certificates and chains has been properly disposed.
_Originally posted by @wfurt in [#133159](https://github.com/dotnet/runtime/pull/133159/changes/BASE..b71a97862a560c9a5cadf6deec2f07e0fd1c3d77#r3938948347)_
We should look at the current test coverage and see if we need to expand it.
Contributor guide
Research direction
Start by locating the existing TlsSession API tests and reviewing their current certificate and chain coverage. Run that test area first, then identify missing disposal scenarios for all certificates and chains; done means the relevant lifecycle cases are covered by tests and pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100