dotnet / dotnet/runtime

WebProxy's BypassProxyOnLocal domain detection could be improved

Open
#132,842 3 comments 2 reactions 1 assignee Claimed by @thaildhe172591 View on GitHub
area-System.Net bug
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

We're looking for the ASCII dot character in the `Uri.Host`, which may also contain other types of dots that `Uri` would otherwise accept.
We may want to use `IdnHost` here instead.

https://github.com/dotnet/runtime/blob/c210d82dbc1ab432b9369604a1caef9a0ab763d2/src/libraries/System.Net.WebProxy/src/System/Net/WebProxy.NonWasm.cs#L33

https://github.com/dotnet/runtime/blob/c210d82dbc1ab432b9369604a1caef9a0ab763d2/src/libraries/System.Net.WebProxy/src/System/Net/WebProxy.Wasm.cs#L20

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.