Reactivate ActiveIssue tests in Microsoft.Extensions where the issue is no longer active
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Description
There are 45 `[ActiveIssue]` attributes in Microsoft.Extensions tests that point to issues that are no longer active (i.e. the issues are closed). I think these tests should be reactivated, if possible. If removing some `[ActiveIssue]` is more complicated, we can create a dedicated issue for it (or ignore it for now).
Specifically:
| Closed issue | Affected tests/scope |
|---|---|
| [runtime#35970](https://github.com/dotnet/runtime/issues/35970) | `Microsoft.Extensions.Caching.Memory.Tests` — assembly-wide, limited to the Mono runtime |
| [runtime#33894](https://github.com/dotnet/runtime/issues/33894) | `ServiceProviderCompilationTest` — class-wide, limited to the Mono runtime; `CompilesInLimitedStackSpace` is also separately marked for Mono |
| [runtime#34091](https://github.com/dotnet/runtime/issues/34091) | 10 tests in `LoggerFactoryExtensionsTest` and `LoggerTest` |
| [runtime#37669](https://github.com/dotnet/runtime/issues/37669), [runtime#73432](https://github.com/dotnet/runtime/issues/73432) | `XmlConfigurationTest.LoadKeyValuePairsFromValidEncryptedXml` |
| [runtime#42036](https://github.com/dotnet/runtime/issues/42036) | `CanSetValuesAndReloadValues`, `CreatingOptionalFileInNonExistentDirectoryWillReload`, `DeletingFilesThatRedefineKeysWithReload`, `DeletingFileWillReload`, `CreatingWritingDeletingCreatingFileWillReload` |
| [runtime#43411](https://github.com/dotnet/runtime/issues/43411) | `DI.External.Tests` — assembly-wide, limited to Browser |
| [runtime#48696](https://github.com/dotnet/runtime/issues/48696) | `HostTests.CreateDefaultBuilder_ConfigJsonDoesNotReload` |
| [runtime#50867](https://github.com/dotnet/runtime/issues/50867) | Three Configuration.Ini tests in `IniConfigurationExtensionsTest` and `IniConfigurationTest` |
| [runtime#50872](https://github.com/dotnet/runtime/issues/50872) | `ReadsRuntimeTargetInfoWithCommentsIsInvalid`, `RejectsMissingLibrary` |
| [runtime#50873](https://github.com/dotnet/runtime/issues/50873) | Six Http tests across `DefaultHttpMessageHandlerBuilderTest`, `HttpMessageHandlerBuilderTest`, and `HttpClientFactoryServiceCollectionExtensionsTest` |
| [runtime#50875](https://github.com/dotnet/runtime/issues/50875) | Five Logging tests in `LoggerFilterTest` and `LoggerMessageTest` |
| [runtime#50877](https://github.com/dotnet/runtime/issues/50877) | `ConfigureOptionsThrowsWithAction`, `ConfigureOptionsThrowsIfNothingFound` |
| [runtime#52062](https://github.com/dotnet/runtime/issues/52062) | `ConfigurationBindingGeneratorTests`, `LoggerMessageGeneratorEmitterTests`, and `LoggerMessageGeneratorParserTests` — class-wide, limited to Browser |
| [runtime#52319](https://github.com/dotnet/runtime/issues/52319) | `FileConfigurationProviderTest.ProviderThrowsInvalidDataExceptionWhenLoadFails` |
| [roslyn#52527](https://github.com/dotnet/roslyn/issues/52527) | `LoggerMessageGeneratedCodeTests.MessageTests_SuppressWarning_WarnAsError_NoError` |
Contributor guide
Research direction
Start by locating the listed Microsoft.Extensions test classes and their [ActiveIssue] attributes, then run the affected tests on the relevant runtimes, including Mono and Browser where noted. Reactivate tests whose referenced issues are closed and still pass; document or separate cases that need more investigation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100