dotnet / dotnet/runtime

JIT: revisit GS protection for ABIs that split structs across stack and registers

Open
#127,657 2 comments 0 reactions 1 assignee Claimed by @AndyAyersMS View on GitHub
area-CodeGen-coreclr
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

We won't introduce shadow params if a struct arg is passed partially on the stack and partially on registers. Seems like we should, if caller-supplied space is used to access the on-stack portion or to hold the spilled register portion.

Note some ABIs that allow split-struct passing reassemble the struct as a normal local, so would not need a shadow param.

See https://github.com/dotnet/runtime/pull/127487

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.