dotnet / dotnet/runtime

[debugger][clr-interp] Investigate whether applying `ApplyTraceFlag` for interpreter is required

Open
#125,050 1 comment 0 reactions 1 assignee Claimed by @matouskozak View on GitHub
area-Diagnostics-coreclr
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Currently, we prohibit calling `ApplyTraceFlag` for interpreter code https://github.com/dotnet/runtime/blob/a55060629d3a0efeb16722baefe253d1668fe681/src/coreclr/debug/ee/controller.cpp#L3512-L3521

This has a consequence that we don't call `SetThreadStateNC(Thread::TSNC_DebuggerIsStepping)` which is used to prevent a thread suspension for stepping thread (see `CheckActivationSafePoint`). Currently, we did not have an issue with this but we should evaluate if the current approach is correct.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.