dotnet / dotnet/runtime

[debugger] Decouple `IExecutionControl` from `DebuggerControllerPatch`

Open
#124,546 4 comments 0 reactions 1 assignee Claimed by @matouskozak View on GitHub
area-Diagnostics-coreclr
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

The current `IExecutionControl` methods currently take `DebuggerControllerPatch*` as parameter in all methods.

Proposal is to narrow the interface to something like:

```cpp
virtual bool ApplyPatch(CORDB_ADDRESS_TYPE* address, PRD_TYPE& originalOpcode);
virtual bool UnapplyPatch(CORDB_ADDRESS_TYPE* address, PRD_TYPE originalOpcode);
virtual void BypassPatch(CONTEXT* context, CORDB_ADDRESS_TYPE* address, PRD_TYPE originalOpcode);
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.