dotnet / dotnet/runtime

[browser][wasm] Array values are not subject to assertions

Open
#123,731 5 comments 0 reactions 1 assignee Claimed by @pavelsavara View on GitHub
arch-wasm area-System.Runtime.InteropServices.JavaScript os-browser
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

### Description

Noticed in https://github.com/dotnet/runtime/pull/123523. Int32 array values can overflow without notification to the user (mono & coreclr show this behavior).

Likely this means no value assertions are performed for arrays in general.

### Reproduction Steps

UnitTest: System.Runtime.InteropServices.JavaScript.Tests.JSImportTest.Int32ArrayWithOutOfRangeValues
(added in https://github.com/dotnet/runtime/pull/123523 might not be on main yet)

### Expected behavior

JSException with overflow message like for other overflow asserts, for tasks thrown to the receiver, for other argument types thrown back to the caller.

### Actual behavior

Int32 overflows, other numerics likely do so too.

### Regression?

_No response_

### Known Workarounds

_No response_

### Configuration

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.