dotnet / dotnet/runtime

[Workloads] Move setup and aliasing out of Versions.props

Open
#122,354 1 comment 1 reaction 0 assignees View on GitHub
area-Workloads
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Move
> Note that reading from another property in Versions.props is an anti-pattern as this will have the wrong value when building from source. That overrides versions after the Versions.props import. We usually put things that read from Version.Details.props / Versions.props into Directory.Build.props.
>
>
>
> Might not matter here if this path isn't exercised in source-build but wanted to mention it.
>
>
>
> See https://github.com/dotnet/sdk/blob/0d31ba892465268a030b3563df0bddef39855f6e/Directory.Build.props#L97 for an example

_Originally posted by @ViktorHofer in [#121853](https://github.com/dotnet/runtime/pull/121853/files#r2588414931)_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.