dotnet / dotnet/runtime

Trimming attributes don't fully handle variance

Open
#120,203 3 comments 1 reaction 2 assignees Claimed by @agocke View on GitHub
area-Tools-ILLink
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Most of the trimming analysis is too conservative in how it handles attributes in override/interface situations.

In overriding, hiding, and interface implementation (OHI):

- [ ] DynamicallyAccessedMembers should allow adding DAMT items in member outputs and removing DAMT items on inputs, but not vice versa.
- [ ] Removing Requires* from an OHI member should be allowed, but not adding

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.