dotnet / dotnet/runtime

System.Runtime.Serialization.Formatters compatibility package exposed some new API

Open
#119,782 9 comments 0 reactions 1 assignee Assigned to @jeffhandley View on GitHub
area-System.Runtime binaryformatter-migration
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

I was reviewing docs files and noticed that the package version of this library exposed two new API over the inbox.
- System.Runtime.Serialization.SerializationEventHandler
- System.Runtime.Serialization.TypeLoadExceptionHolder

It looks to me like these were intentionally omitted from the reference assembly
https://github.com/dotnet/runtime/blob/2bd4439c7cc527a9fb37824a648ccad4b2128de2/src/libraries/System.Runtime.Serialization.Formatters/src/CompatibilitySuppressions.xml#L4-L11

But the package doesn't ship that (nor could it force folks to only use it if it did) so those public members from the implementation are exposed.

Not sure if this is problematic or not, but thought I'd let the owners make the call.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.