dotnet / dotnet/roslynator

RCS1097 False Negative 4

Open
#519 0 comments 0 reactions 0 assignees View on GitHub
Area-Analyzers Feature Request
Dominant language
C#
Stars
3.5k
Forks
294
Avg merge
2h 30m
Merged PRs (30d)
4

Description

RCS1097 isn't flagged on ```address.ToString()```. Is this a false negative?

```csharp
using System.Net;
using System.Text;

namespace RCS1097_False_Negative
{
static class Class
{
static void M(IPAddress[] ipaddressarray)
{
StringBuilder addressList = new StringBuilder();
foreach (IPAddress address in ipaddressarray)
{
addressList.Append(address.ToString());
}
}
}
}
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the RCS1097 case from this issue using the provided C# example, focusing on address.ToString() inside StringBuilder.Append. Trace the analyzer behavior for this expression and determine whether it should be flagged; done means the expected diagnostic behavior is covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.