dotnet / dotnet/roslynator

RCS1019 IDE0036 Inconsistency

Open
#427 8 comments 2 reactions 1 assignee Claimed by @josefpihrt View on GitHub
Area-Analyzers Resolution-By Design
Dominant language
C#
Stars
3.5k
Forks
294
Avg merge
2h 30m
Merged PRs (30d)
4

Description

If I use the recommended editorconfig settings concerning modifier order at: https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference#example-editorconfig-file

```
# Modifier preferences
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
```

Reviewing the following code: RCS1019 wants new to come before public, IDE0036 wants new to come after public.
```csharp
namespace RCS1019_IDE0036_Inconsistency
{
public class Console
{
public new bool Equals => true;

new public bool ReferenceEquals => true;
}
}
```

Is this by design or should RCS1019 be changed to match Microsoft's IDE0036 default recommendation?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.