dotnet / dotnet/roslynator

Overlap with VS 15.5.1 IDE refactorings

Open
#227 0 comments 0 reactions 0 assignees View on GitHub
Area-Analyzers
Dominant language
C#
Stars
3.5k
Forks
294
Avg merge
2h 30m
Merged PRs (30d)
4

Description

If a private method does not have the `private` keyword, in VS 15.5.1, two refactoring with the same behavior appear:

* Add default access modifier (from Roslynator)
* Add accessibility modifier (from VS)

For refactorings that are redundant with those in the IDE, Roslynator should disable its or the IDE's version of the refactoring.

Contributor guide

Open the contributing guide

Research direction

Reproduce the overlap in Visual Studio 15.5.1 with a private method that lacks the private keyword, then compare Roslynator's "Add default access modifier" with Visual Studio's "Add accessibility modifier." Done means deciding which redundant refactoring should be disabled and confirming that only one action remains available.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.