dotnet / dotnet/roslyn

Move target path calculation out of MSBuild

Open
#85,631 2 comments 0 reactions 1 assignee Claimed by @chsienki View on GitHub
Area-Razor Area-Razor-Compiler
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

We should move the target path calculation from MSBuild into the source generator always. We have the project file passed in, so the calculation is trivial to do in the generator directly.

My suspicion for _why_ it was done like this is that the old pre-SG way of compiling had logic in MSBuild for target path calculation, and the authors didn't want to have a duplicate that could get out of sync.

_Originally posted by @chsienki in https://github.com/dotnet/razor/pull/12355#discussion_r2461226709_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.