dotnet / dotnet/roslyn

It looks like `InConversionGroupFlags.UserDefinedReturnTypeAdjustment` is never actually used

Open
#85,267 0 comments 0 reactions 0 assignees View on GitHub
Area-Compilers Concept-Design Debt
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

It looks like we do not have a single unit-test that exercises a code path that uses ```InConversionGroupFlags.UserDefinedReturnTypeAdjustment```. We have code that is supposed to use it, but it appears that the code is not reachable in practice. We should either add proper test coverage, or remove the dead code and the flag in order to reduce complexity.

Contributor guide

Open the contributing guide

Research direction

Start by locating InConversionGroupFlags.UserDefinedReturnTypeAdjustment and the code paths that are supposed to use it. Review existing unit-test coverage to determine whether the flag is reachable in practice. Done means either a test covers the reachable behavior or the dead code and flag are removed, based on the investigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
compilers, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.