dotnet / dotnet/roslyn

Move our LSP MEF container to dispose asynchronously

Open
#85,121 0 comments 0 reactions 0 assignees View on GitHub
Area-IDE
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

https://github.com/microsoft/vs-mef/pull/781 added support to VS-MEF to support disposing the container asynchronously. https://github.com/dotnet/roslyn/pull/84982 switched some of our MEF exports to be IAsyncDisposable and they might not be getting disposed right now.

Contributor guide

Open the contributing guide

Research direction

Start by reading microsoft/vs-mef#781 and dotnet/roslyn#84982 to understand the asynchronous container disposal support and the IAsyncDisposable exports. Locate the LSP MEF container and verify its shutdown path uses asynchronous disposal; done means those exports are disposed when the container is shut down.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.