dotnet / dotnet/roslyn

Closed class: Ensure IsClosedTypeAttribute.DerivedTypes and symbol APIs use the same order

Open
#84,416 0 comments 0 reactions 1 assignee Claimed by @RikkiGibson View on GitHub
Area-Compilers Feature - Closed Class Hierarchies
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

In reference to `IsClosedTypeAttribute.DerivedTypes` property, and symbol APIs such as `ITypeSymbol.GetClosedSubtypeInfo`, there is a possibility that a closed class imported from metadata will list the same derived types, but in a different order, from these two locations.

---

I do not think this issue is blocking for this PR, or blocking for shipping the feature. However, I think that this behavior is not ideal. An ideal behavior, in my opinion, would be to not observe any difference in compiler or public API behavior for compilation vs. metadata reference scenarios. Consider opening a tracking issue.

_Originally posted by @AlekseyTs in https://github.com/dotnet/roslyn/pull/84350#discussion_r3529361742_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.