Microsoft.CodeAnalysis.LanguageServer: Reason not to include a one liner to add VB.net support?
- Dominant language
- C#
- Stars
- 20.7k
- Forks
- 4.3k
- PR merge metrics
- PR metrics pending
Description
I was messing around with trying to get https://github.com/seblyng/roslyn.nvim working with VB.net. All I had to do to get the LSP to work with VB.net was to add a one liner in CodeAnalysis.LanguageServer.csproj: a project reference to CodeAnalysis.VisualBasic.Features.vbproj.
This is extremely useful to me, and I was wondering if there was an explicit design decision for omitting VB from the LSP? I'm assuming there's a reason behind this, but that one reference allows me to get what seems like full LSP support for VB.net
edit: Working concept in a fork I made here: https://github.com/misterkiem/roslyn-plusvb . I made other changes to get it to build in my environment, and to get it working for Mason, but that shouldn't be necessary. All that's necessary is the one project reference
Contributor guide
Research direction
Start with CodeAnalysis.LanguageServer.csproj and the referenced CodeAnalysis.VisualBasic.Features.vbproj. Compare the working concept in the linked roslyn-plusvb fork, then determine whether adding the project reference provides the intended VB.NET LSP support without the fork's other changes. Done means the design rationale is established and the resulting language-server build and support behavior are verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100