dotnet / dotnet/roslyn

Follow-ups to "Refactor fbp workspace management" (#82509)

Open
#82,855 0 comments 0 reactions 1 assignee Claimed by @RikkiGibson View on GitHub
Area-IDE Feature - Run File
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

I think we discussed that MiscellaneousFileWithNoReferences doesn't really make much sense as a state -- in that case it'd be good to delete this. I think you had a follow up on that?

_Originally posted by @jasonmalinowski in https://github.com/dotnet/roslyn/pull/82509#discussion_r2956914908_

@dibarbet:
> I think it makes sense for the option, but I am OK with removing that option (and just having the FBP one).

@RikkiGibson:
> I think that at minimum the helper `ClassifyAsMiscellaneousFileWithNoReferences` makes sense to have. The reason we wouldn't want to have it here is: we can't make `ProjectFileInfo` for `MiscellaneousFileWithNoReferences`. It's too painful to maintain both that and the existing path that produces `ProjectInfo`.
>
> I'm going to file a follow-up for cleaning this up.

---

To call this out, since you had that issue with the project path being not a "real" path -- this is setting the path of a project as created in the workspace. This may be unnecessary to set and instead could be overridden to null.

_Originally posted by @jasonmalinowski in https://github.com/dotnet/roslyn/pull/82509#discussion_r2956836462_

---

- [ ] Delete extra debug logging from the canonical provider
- [ ] Try putting back the new TargetFramework variable into canonical project XML

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.