dotnet / dotnet/roslyn

Extensions: follow-up to confirm effect of Endianness on marker type name

Open
#79,374 0 comments 0 reactions 1 assignee Claimed by @jcouv View on GitHub
Area-Compilers Feature - Extension Everything
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

We're not completely sure whether some adjustment for Endianness is needed or not... See [discussion](https://github.com/dotnet/roslyn/pull/79308#discussion_r2198235986)

```
if (!BitConverter.IsLittleEndian)
{
l2 = BinaryPrimitives.ReverseEndianness(l2);
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.