dotnet / dotnet/roslyn

BasicRename.VerifyAttributeNotCapitalizedRename fails despite try/catch

Open
#79,300 1 comment 0 reactions 0 assignees View on GitHub
Area-Infrastructure untriaged
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

Rename is not leaving the cursor at the end of the identifier. It seems like the cursor location is a known problem that we tried to work around. `TrueException` is a `XunitException` so not sure why this isn't working for us.
https://github.com/dotnet/roslyn/blob/334d4c7ade78170d7b06448a2807627ddb96d742/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicRename.cs#L384-L403
Screen cap from failing CI run:
image

Contributor guide

Open the contributing guide

Research direction

Start with src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicRename.cs at lines 384-403 and reproduce BasicRename.VerifyAttributeNotCapitalizedRename from the failing CI run. Inspect the cursor-location workaround and try/catch behavior; done means the rename test passes and leaves the cursor at the end of the identifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, visualbasic
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.