dotnet / dotnet/roslyn

Add Parameter code fix can modify read-only documents

Open
#79,075 0 comments 0 reactions 1 assignee Claimed by @JoeRobich View on GitHub
Area-IDE IDE-CodeStyle
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

I ran the "Add parameter" refactoring, mistakingly thinking it did something differentt to what it does, and it tried to add the new parameter to all calls of the method. The problem is one of the calls came from the CLaSP source package, and it dutifuly modified the file on disk, which broke my build due to CS8300 (Merge conflict marker encountered), but when I try to go to the document to fix it, it's read only and I can't.

![Image](https://github.com/user-attachments/assets/ebbf6c82-8bb7-4d35-9097-e7cbf4fb5144)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.