RS1019 does not analyze suppression descriptions
- Dominant language
- C#
- Stars
- 20.7k
- Forks
- 4.3k
- PR merge metrics
- PR metrics pending
Description
I just noticed that suppression descriptors are not analyzed by RS1019 etc (https://github.com/dotnet/roslyn/blob/241d91b57703f837cc3e02c1c0b49f7383efde5d/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticDescriptorCreationAnalyzer.cs).
I suspect that all descriptor ids should be unique, regardless of if they are used by analyzers or suppressors?
Contributor guide
Research direction
Start by reading src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticDescriptorCreationAnalyzer.cs and trace how RS1019 handles descriptors used by suppressors. Determine the expected uniqueness and analysis behavior for suppression descriptors, then verify the change with the relevant analyzer tests; done means those descriptors are analyzed consistently with analyzer descriptors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- compilers, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100