dotnet / dotnet/roslyn

Collection expression arguments: CollectionBuilder items parameter should be last

Open
#77,866 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature - Dictionary Expressions
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

For `CollectionBuilderAttribute` create methods, the `ReadOnlySpan` parameter for items should be last rather than first.

See [LDM-2025-03-12](https://github.com/dotnet/csharplang/blob/main/meetings/2025/LDM-2025-03-12.md#collection-builder-method-parameter-order).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked LDM-2025-03-12 discussion and search the Roslyn compiler for CollectionBuilderAttribute create methods. Verify the collection expression handling and update it so the ReadOnlySpan items parameter is last, with tests covering the parameter order.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.