dotnet / dotnet/roslyn

[LSP] Do not recompute syntax diagnostics if syntax has not changed

Open
#75,241 0 comments 0 reactions 1 assignee Claimed by @dibarbet View on GitHub
Area-Analyzers Area-IDE LSP
Dominant language
C#
Stars
20.7k
Forks
4.3k
PR merge metrics
PR metrics pending

Description

Currently we always use the project dependent checksum to determine if there are any changes that might impact diagnostics - https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Protocol/Handler/Diagnostics/AbstractPullDiagnosticHandler.cs#L165

The request from the client is that for syntax diagnostic sources, we use the document / syntax only checksum to determine if there have been changes. This avoids unnecessary recomputation of the syntax only diagnostics when there is a change in another file for example

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.