dotnet / dotnet/roslyn-tools

SpecificBuildNumber must not be specified along with DropPath

Open
#855 0 comments 1 reaction 1 assignee Claimed by @RikkiGibson View on GitHub
Dominant language
C#
Stars
109
Forks
85
Avg merge
2d 16h
Merged PRs (30d)
1

Description

In many of our AzDo pipelines we have an artifact for Roslyn which we download via the AzDo mechanisms to save time (by reading it in using the DropPath argument):

![image](https://user-images.githubusercontent.com/5833655/99321493-cb50c780-2822-11eb-87de-27140e9a290b.png)

But we also have a SpecificBuildNumber property:

![image](https://user-images.githubusercontent.com/5833655/99321523-df94c480-2822-11eb-9f77-16f1726d0964.png)

Giving a SpecificBuildNumber that contradicts the artifacts in the DropPath causes a really bad failure mode, where the title of the PR and the diff of changes shows one changeset, and the version numbers that are actually being inserted can be completely unrelated. See https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/288025?view=discussion for example.

tagging @JoeRobich @ryzngard

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.