dotnet / dotnet/roslyn-tools

Insertion tool needs to respect updateRevisions.txt

Open
#223 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
109
Forks
85
Avg merge
2d 16h
Merged PRs (30d)
1

Description

The insertion tool right now (I believe) won't respond to updateRevisions.txt files, since it does the commit via libgit2sharp which won't do the commit hooks. This is bad, because it means we won't update revision.txt files that we need to do in some cases, like assembly version changes.

We could fix this in two ways:

1. Shell out to git commit which will run the hooks.
2. Shell out to the hook directly.
2. Reimplement the support in the insertion tool.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the insertion tool and its libgit2sharp commit path, then inspect how updateRevisions.txt, revision.txt, and commit hooks are handled. Reproduce an insertion that should update revision.txt and compare the result with a hook-enabled Git commit; done means the required revision updates occur reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, git
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.