dotnet / dotnet/reactive

Should we dispose Timer in ControlScheduler?

Open
#2,272 0 comments 0 reactions 0 assignees View on GitHub
[area] Rx
Dominant language
C#
Stars
7.2k
Forks
798
PR merge metrics
No merged PRs in 30d

Description

GitHub Copilot reviewed #2268 and pointed out that we apparently do not `Dispose` the `Timer` objects we create.

Since this wasn't actually new code—this has been in Rx for years, and has simply moved in this PR—that PR did not seem the right place to address this.

On the face of it, Copilot seems to be correct, but the code handling teardown is complex due to multithreading issues, so it needs a closer look.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.