dotnet / dotnet/reactive

AsyncRx.NET Distinct and DistinctUntilChanged should be extension methods

Open
#2,169 0 comments 0 reactions 0 assignees View on GitHub
[area] AsyncRx
Dominant language
C#
Stars
7.2k
Forks
798
PR merge metrics
No merged PRs in 30d

Description

#### Bug

The `AsyncObservable` class's static `Distinct` and `DistinctUntilChanged` methods are not extension methods. This means that given some:

```cs
IAsyncObservable xs = GetNums();
```

you can't write this:

```cs
xs.Distinct(); // or DistinctUntilChanged
```

You have to write this:

```cs
AsyncObservable.Distinct(xs);
```

This seems like a straightforward oversight. We just need to add the `this` keyword to these methods.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.