dotnet / dotnet/reactive

Consider returning an empty collection instead of an exception for MaxByAsync/MinByAsync

Open
#2,166 2 comments 0 reactions 0 assignees View on GitHub
[area] Ix
Dominant language
C#
Stars
7.2k
Forks
798
PR merge metrics
No merged PRs in 30d

Description

#### Feature request

**Behavior change on an existing operator.**

> Which subcomponent library: Async.Ix

> Which next library version: major (runtime behaviour breaking change)

> Please describe the feature.

The versions of this method in the framework only throw exceptions for ValueTypes, instead preferring to return null for reference types. In the spirit of this, it may be worth returning the empty List from these methods instead of throwing an error. I'll probably put together a branch with this on later this week for consideration and our own internal use.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.