dotnet / dotnet/reactive

Remove AsyncEnumberable.ToEnumerable or at least warn about usage

Open
#1,835 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
7.2k
Forks
798
PR merge metrics
No merged PRs in 30d

Description

see https://github.com/dotnet/reactive/blob/9f2a8090cea4bf931d4ac3ad071f4df147f4df50/Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToEnumerable.cs#L12

It seems very easy to call ToEnumerable on an AsyncEnumerable but it breaks all the nice async behavior. There should be at least a warning in the xmldoc, that it is a synchronous way to access the data.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.