dotnet / dotnet/project-system
Saving a CPS multi-targeting project unglobbed net45 subtypes
Open
Feature-Project-File-Simplification
Triage-Approved
- Dominant language
- C#
- Stars
- 1k
- Forks
- 415
- PR merge metrics
- No merged PRs in 30d
Description
Look at this commit:
https://github.com/onovotny/microsoft-authentication-library-for-dotnet/commit/f8880e6a7ff4b0e586d6195c57ca9fac9b9bf4d3
All I did was change net45 to be first in the order but then VS expanded a bunch of crapL
https://github.com/onovotny/microsoft-authentication-library-for-dotnet/commit/f8880e6a7ff4b0e586d6195c57ca9fac9b9bf4d3#diff-9abb1283a16cd21deac528e4738327f7R147 by adding the `Form` elements. I don't want those in my glob.
It's worse than that too as it put those elements in a top-level item group without any conditions on it. None of the other TFM's should even see that file, that's wrong.
Contributor guide
Assessment
This issue has not been assessed yet.