dotnet / dotnet/project-system

Improve NuGet restore loop detection

Open
#9,142 5 comments 0 reactions 1 assignee Claimed by @drewnoakes View on GitHub
Feature-NuGet Performance-Scenario-General Tenet-Performance Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

Recently in #9051 we added NuGet restore loop detection that handled the case where project data alternated between two states, similar to ABABABAB...

In [AB#1786477](https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_workitems/edit/1786477), another endless restore was reported where the sequence of states constantly changes without repeating (more like ABCDEFGHIJ...).

We should identify this scenario too, break the runaway restores and notify the user (as we do for the cycle case).

To repro:

1. Create a new Console App project.
1. Add the following property to the `.csproj`:
```xml
1.0-preview$([System.DateTime]::Now.ToString(`yyMMddHHmmss`))
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.