dotnet / dotnet/project-system

Insertion description doesn't handle reverted insertions

Open
#9,013 0 comments 0 reactions 0 assignees View on GitHub
Area-Infrastructure Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

## Summary
The insertion description logic looks for `Insert DotNet-Project-System` (among other things). When one of these PRs is reverted, the name of that reverted insertion is `Revert 'Insert DotNet-Project-System`, which is detected by this process. These would have to be ignored to process the description properly.

## Insertions
- Original insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/471309

![image](https://github.com/dotnet/project-system/assets/17788297/bab63f19-755e-4b9d-b9b0-0257ccc87f95)

- Reverted insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/471482

![image](https://github.com/dotnet/project-system/assets/17788297/1219348a-8391-4649-ab52-f9a5096c4aa5)

- Insertion again: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/471546

![image](https://github.com/dotnet/project-system/assets/17788297/5e34fb48-56ee-4a8f-8fbb-1df5fe4c3e7d)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.