dotnet / dotnet/project-system

Remove hardcoded map values s_packageVersionToComponentId

Open
#8,186 0 comments 0 reactions 0 assignees View on GitHub
Feature-Acquisition Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

We have to improve the design `MissingRuntime` to be less fragile whenever Msft adds new runtime versions.

We have to remove the hardcoded map [s_packageVersionToComponentId ](https://github.com/dotnet/project-system/blob/9b48763c683a37fa8c09bef7ec40259c41563a11/src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Runtimes/MissingSdkRuntimeDetector.cs#L13) that contains the relation (RuntimeVersion, ComponentId).

Since Sdk manages this information (runtime versions and component Ids), we have created the GitHub [#25575](https://github.com/dotnet/sdk/issues/25575) to request a new design-time msbuild item that can provide the componentId of a missing runtime.

Once [#25575](https://github.com/dotnet/sdk/issues/25575) is completed, we have to update the design of `MissingSdkRuntimeDetector` to read the `componentId` from the new design-time msbuild item.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.