dotnet / dotnet/project-system

Improve cancellation support in LaunchSettingsProvider

Open
#7,056 3 comments 0 reactions 1 assignee Claimed by @tmeschter View on GitHub
Feature-Debugging Triage-Investigate
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

The `LaunchSettingsProvider` handles concurrent modifications by queuing them up in a `SequentialTaskExecutor` where they are processed one at a time. Once a `Task` is queued up there is no way of cancelling it, with the exception that disposing the `LaunchSettingsProvider` will cancel all pending `Task`s.

We should looking into updating `LaunchSettingsProvider` (and `ILaunchSettingsProvider`) to accept and respect `CancellationToken`s.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.