dotnet / dotnet/project-system

File Nesting: Warnings from File Nesting are returning the wrong data for Error List properties

Open
#6,641 1 comment 0 reactions 1 assignee Assigned to @smitpatel View on GitHub
Bug Bash Feature-File-Nesting Triage-Investigate
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

The file nesting feature is populating the error list but has two problems with the data its returning:

![image](https://user-images.githubusercontent.com/1103906/94775315-ee562200-0402-11eb-9fa4-d88e7e94d18b.png)

1) ~It's always returning a value for `StandardTableKeyNames.FullText`, confusing the Error List into thinking that it has expandable "Description", when it's just repeating the contents of the text. You can see in contrast to the Compiler error which does the right thing. See src\Microsoft.VisualStudio.ProjectSystem.VS.Implementation\Build\BuildErrorsTableDataSource.cs for the correct way to handle this. It should only return FullText for errors that span multiple lines.~ PR: [278832](https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/278832)

2) It isn't correctly returning a value for `StandardTableKeyNames.ProjectGuid` so "Project Rank" isn't being set.

3) It isn't returning a value for `StandardTableKeyNames.ProjectName`, so "Project" column isn't being set

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.