dotnet / dotnet/project-system

IVsHierarchy Project GUID might not be initialized at the time AbstractLegacyproject reads it

Open
#4,930 7 comments 0 reactions 1 assignee Claimed by @tmeschter View on GitHub
Blocking-Partner Feature-Codespaces Legacy Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

For some legacy projects (e.g. legacy VB WPF app) the project system does not initialize Project GUID on IVsHierarchy before calling to Roslyn to construct the project.

Furthermore, it is unclear if the Project GUID passed to Roslyn is actually uniquely identifying the project or if it can be shared across multiple projects.

We need Project GUIDs that are stored on IVsHierarchy to uniquely identify projects created in Roslyn.

See also:
https://github.com/dotnet/roslyn/pull/36512
fixes [DevDiv 915798](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/915798)
https://github.com/dotnet/roslyn/issues/36516

This issue is blocking work on VS SaaS.

Also tracked by [AB#981311](https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_workitems/edit/981311)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.