dotnet / dotnet/project-system

Get syntax errors/invalid colorization on project load when you've customized the version

Open
#4,303 0 comments 1 reaction 1 assignee Claimed by @davkean View on GitHub
Feature-Language-Service Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

When you've customized the language version, or you have a restored document with a #if DEBUG (and DEBUG is the active configuration), you get wrong colorization in source files, or get incorrect syntax errors in the error list:

![image](https://user-images.githubusercontent.com/1103906/48831494-0dc5a200-edcb-11e8-9216-68af24ad87c4.png)

This is because correct conditional constants and language version only gets set once a design-time build has completed. We should fix that and set all parse options up-front and during evaluation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.