dotnet / dotnet/project-system

All-configs property settings should be unconditional

Open
#1,388 5 comments 0 reactions 1 assignee Claimed by @davkean View on GitHub
Feature-Rules/Properties Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

I created a new project multitargeted to `net46;netstandard1.3`. I went to project properties -> Build, selected "All Configurations" and "All Platforms", and checked the "Allow unsafe code" box. Instead of a simple unconditional addition of the property

```xml
True
```
in the existing unconditional `PropertyGroup`, the project file change is

```diff
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
+
+
+ True
+
```

The former is both more succinct and easier to later extend to new configurations.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.