dotnet / dotnet/project-system

RESX code generation does not respect <LogicalName>

Open
#1,058 5 comments 0 reactions 1 assignee Claimed by @davkean View on GitHub
Feature-Resource-Explorer Triage-Approved
Dominant language
C#
Stars
1k
Forks
415
PR merge metrics
No merged PRs in 30d

Description

The RESX code generation does not respect the `` metadata item on a `` item.

For example, the following:

``` XML

Microsoft.VisualStudio.Editors.Designer.resources
Designer
My.Resources
ResXFileCodeGenerator
Designer.Designer.vb

```

Should result in code gen with:

``` VB
Friend Shared ReadOnly Property ResourceManager() As Global.System.Resources.ResourceManager
Get
If Object.ReferenceEquals(resourceMan, Nothing) Then
Dim temp As Global.System.Resources.ResourceManager = New Global.System.Resources.ResourceManager("Microsoft.VisualStudio.Editors.Designer", GetType(Designer).Assembly)
resourceMan = temp
End If
Return resourceMan
End Get
End Property
```

but actually results in:

``` VB
Friend Shared ReadOnly Property ResourceManager() As Global.System.Resources.ResourceManager
Get
If Object.ReferenceEquals(resourceMan, Nothing) Then
Dim temp As Global.System.Resources.ResourceManager = New Global.System.Resources.ResourceManager("Designer", GetType(Designer).Assembly)
resourceMan = temp
End If
Return resourceMan
End Get
End Property
```

We hit this fixing: https://github.com/dotnet/roslyn-project-system/issues/1056

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.