dotnet / dotnet/performance

[bug] The dotnet/runtime version retrieved for SDK perf scenarios belongs to dotnet/dotnet

Open
#4,847 0 comments 1 reaction 1 assignee Assigned to @Copilot View on GitHub
bug
Dominant language
F#
Stars
773
Forks
301
Avg merge
6d 9h
Merged PRs (30d)
15

Description

The dotnet/runtime version retrieved for SDK perf scenarios stopped working since the deployment of VMR. https://github.com/dotnet/performance/blob/0cd6e3e4914c31ac05e24ffc658b0af2f6897fed/src/scenarios/shared/versionmanager.py#L40

The presented version now comes from dotnet/dotnet repo instead of dotnet/runtime repo. That is because in `get_sdk_versions` we are reading `VersionInfo` property from the used .dlls but since the dlls are now built as part of dotnet/dotnet they carry the version from there.

As a workaround, the actual dotnet/runtime commit can be retrieved by reading the `commitSha` from [https://github.com/dotnet/dotnet/blob/{dotnet/dotnet_hash}/src/source-manifest.json#L109-L113](https://github.com/dotnet/dotnet/blob/%7Bdotnet/dotnet_hash%7D/src/source-manifest.json#L109-L113).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.