dotnet / dotnet/performance

Report Generation Fix and Improvement list post #3180

Open
#3,183 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
F#
Stars
773
Forks
301
Avg merge
6d 9h
Merged PRs (30d)
15

Description

The root of the #3180 issue seems to have been file versions being passed through rather than replaced with VERSION in the SOD tool, or files changing in general. More specifically, there were some files with names like dotnet.native.8.0.0-ci.\.js.* or dotnet.runtime.8.0.0-ci.\.js.* that should have had the replaced with VERSION by the SOD tool. While we have a mitigation, there are some follow items to complete:

- [ ] Investigate why the version is not being replaced properly by the SOD tool
- [ ] Backfill the incorrectly versioned data with correctly versioned data. The version should be replaced with 'VERSION'. Look at correctly replaced files for reference.
- [ ] Bubble up the exceptions around line 167 in program.cs (I think) so that batch explorer shows as failed while not failing all reports. A potential solution for this is to create a hasFailed global that is then set to the return value, returning 0 on successful run or something else on failure.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.