Orleans_DesignTimeBuild CompilerVisibleProperty breaks fast up-to-date check

The Orleans_DesignTimeBuild property is getting generated into the GeneratedMSBuildEditorConfig.editorconfig file using this item:

https://github.com/dotnet/orleans/blob/1aef90b6f337f955fd67b72fb585474cc7e239cc/src/Orleans.CodeGenerator/build/Microsoft.Orleans.CodeGenerator.props#L4

If the project was first built from command line, the property is not set. If it's subsequently open in the IDE and a design-time build runs for the project, the file is overwritten with the true value:

After that if a build command is issued, the IDE will decide to rebuild the project even if nothing has really changed, since the generated MSBuild editorconfig is considered an input for the fast up-to-date check. That build will overwrite the file again, removing DesignTimeBuild = true.

This will keep flip-flopping.

With modern source generators supporting Balanced execution mode (only run on Save and Build in the IDE), perhaps the custom logic to check for design-time build given an MSBuild property passed to the compiler is no longer required?

@ReubenBond