Double-deep-copy intentionall?
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 10.9k
- Forks
- 2.1k
- Avg merge
- 13h 56m
- Merged PRs (30d)
- 351
Description
Hey there
Is it the intention to double-deep-copy the response in InsideRuntimeClient?
After invoking, the response is copied explicitly
https://github.com/dotnet/orleans/blob/main/src/Orleans.Runtime/Core/InsideRuntimeClient.cs#L285
Inside SafeSendResponse, another deep copy
https://github.com/dotnet/orleans/blob/main/src/Orleans.Runtime/Core/InsideRuntimeClient.cs#L338
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/Orleans.Runtime/Core/InsideRuntimeClient.cs around lines 285 and 338, tracing how the response is copied after invocation and inside SafeSendResponse. Determine whether both copies are required for runtime safety, then confirm the intended behavior and add or update coverage if the project has a relevant test entry point.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100