Undisposed Cancellation Tokens Sources
- Dominant language
- C#
- Stars
- 10.9k
- Forks
- 2.1k
- Avg merge
- 14h 42m
- Merged PRs (30d)
- 354
Description
There are multiple places with undisposed `CancellationTokenSource`, potentially leading to leaks due to unreleased memory.
For instance,
https://github.com/dotnet/orleans/blob/92e0bf37048cd8e6c728fba008fd4cfbbd647435/src/Orleans.Runtime/Catalog/Catalog.cs#L286
https://github.com/dotnet/orleans/blob/92e0bf37048cd8e6c728fba008fd4cfbbd647435/src/Orleans.Runtime/Catalog/Catalog.cs#L367
The issue is opened by comment:
_Originally posted by @ReubenBond in https://github.com/dotnet/orleans/pull/9080#discussion_r1689782729_
Contributor guide
Research direction
Start with the two cited locations in src/Orleans.Runtime/Catalog/Catalog.cs and inspect how each CancellationTokenSource is created, used, and owned. Search the surrounding Orleans.Runtime code for similar undisposed sources; done means the identified sources have a clear disposal path without breaking cancellation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100