dotnet / dotnet/orleans

`UseUnixSocketConnection` not working

Open
#8,969 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
10.9k
Forks
2.1k
Avg merge
15h 1m
Merged PRs (30d)
345

Description

There seems to be a typo in the service registration
https://github.com/dotnet/orleans/blob/722be42f1646d1c0c85de0a70d492a2ca7f1a5d6/src/Orleans.TestingHost/UnixSocketTransport/UnixSocketConnectionExtensions.cs#L16

It registers with the service type `object` instead of `IConnectionFactory`.

Simply dropping the `object` part on those lines fixes the registration:
```
services.AddKeyedSingleton(SiloConnectionFactory.ServicesKey, CreateUnixSocketConnectionFactory());
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.