LocalReminderService Participate() ignores timeout
Open
Needs: triage :mag:
- Dominant language
- C#
- Stars
- 10.9k
- Forks
- 2.1k
- Avg merge
- 15h 1m
- Merged PRs (30d)
- 345
Description
https://github.com/dotnet/orleans/blob/5ea07d68e892c4cb9c81c64555092663a61cf0dc/src/Orleans.Reminders/ReminderService/LocalReminderService.cs#L75-L78
The linked cancellation token source `cts` is not actually used.
IIRC, this could be done with a single CancellationTokenSource:
```C#
using var cts = CancellationTokenSource.CreateLinkedTokenSource(ct);
cts.CancelAfter(initTimeout);
await this.QueueTask(Start)
.WithCancellation(cts.Token, $"Starting ReminderService failed due to timeout {initTimeout}");
```
Contributor guide
Assessment
This issue has not been assessed yet.