dotnet / dotnet/msbuild

[Feature Request]: Update Spectre.Console and fix source-build-externals patches

Open
#9,603 0 comments 0 reactions 0 assignees View on GitHub
backlog Feature Request triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

### Summary

When the next version of Spectore.Console after [0.48.0](https://github.com/spectreconsole/spectre.console/releases/tag/0.48.0) is released, we need to update our source-build mapping.

This involves

* updating the git submodule at https://github.com/dotnet/source-build-externals/tree/main/src to the new spectre tag
* updating this version number to match: https://github.com/dotnet/source-build-externals/blob/main/repo-projects/spectre-console.proj#L6
* adding the `UseBuildTimeTools` property set to `false` to the `BuildCommandArgs` in the spectre repo-project wrapper: https://github.com/dotnet/source-build-externals/blob/main/repo-projects/spectre-console.proj#L21
* deleting this patch since the property fixes the same problem: https://github.com/dotnet/source-build-externals/blob/main/patches/spectre-console/0001-remove-packagereferences-for-build.patch
* Remove the file cloaking configured in https://github.com/dotnet/installer/pull/18110

### Background and Motivation

Just general cleanliness/up-to-date stuff.

### Proposed Feature

Not a feature _per se_.

### Alternative Designs

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.