dotnet / dotnet/msbuild

Consider adding EventArgs infrastructure unit tests

Open
#9,102 1 comment 1 reaction 0 assignees View on GitHub
Area: Logging backlog Priority:2 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

During investigation of https://github.com/dotnet/msbuild/issues/9098 I identified few unit tests missing coverage:

a) binlog end to end test
- prepare small test solution of 2 projects to assure out of proc build
- built it with /v:diag /bl /m and capture console
- replay bin log and capture output
- compare those two captures, they shall be identical
- rinse and repeat for /flp:v=diag /bl /m /tl and compare resulted file loggers outputs

b) events delivery verification
- prepare small test solution of 2 projects to assure out of proc build
- use small catch-em-all loggers which would capture all events into memory (I think existing `MockLogger` can be used here)
- assert some subset of messages from captured list

-----

@AR-May - optionally it could be part of #9098 fix

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.